Repository navigation
Conversation
… switch window on failed restarts A failed start retains its resources while the helper may still be importing them; if that helper hangs past the confirm wait, nothing retried the cleanup and the g_dev || g_helper guard blocked every later fgb_start for the session. The start guard now polls the helper with a zero timeout and finishes cleanup_failed_start once it has exited. Also destroy the freshly made switch child window when the restart fails after it was created (no helper owns it; leaving it occludes the game's fallback picture). Co-Authored-By: Claude Code <noreply@anthropic.com>
Author
|
Code review of this branch found three lifecycle issues on rare failure paths; two are fixed in 73d5b08, one documented:
|
Author
|
Build evidence for 73d5b08 with the pinned llvm-mingw 20261006-ucrt-ubuntu-22.04-x86_64 (tarball SHA-256 5f9c6ed9…, as recorded):
Not installed anywhere — this build exists to prove the fix compiles; your Windows CI remains the release path. |
eayankov
marked this pull request as draft
November 8, 2026 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: AttilaCPUPerfFix — Proton support for the Upscaling and Framegen add-on
Branch:
proton-fixes→main· Commits: 2 (0b94285,6f994f1) · Base:e0f9b9c(6.10.6)What this does
Upscaling repo PR.
Lets the game-side DLL and the separate helper64.exe exchange GPU frames on
Proton (Linux/Wine), where the add-on previously could not run:
0b94285Publish frame bridge shared handles for helper duplication.The bridge publishes its shared color/depth/motion resources as named
handles plus a fixed-width sidecar file (
fgb_handles.h) so a 64-bithelper in another process can duplicate and import them. The existing
named-open transport for older peers is kept; a missing sidecar selects it,
an invalid one fails explicitly.
6f994f1Clean up failed frame bridge initialization. If helperstartup fails, acquired resources are released after the helper's exit is
confirmed, and the job-object handle is retained until exit and closed
after — a later valid launch can initialize cleanly.
Verification status (honest state)
battle sessions with active Quality FSR (thousands of SR round trips, no
timeouts, no present failures); menu upscaling works; duplicated-handle
transport exercised through a standalone cross-process GPU probe (both
formats, contents verified, bidirectional fences).
invalid-sidecar/failure paths (the cleanup commit's behavior is
source-reviewed and mock-tested only).
game falls back to native rendering; live recovery is deliberately out of
scope for this change.
(
Empire.Retail.dll+0x1617248, read 0xD) reproduce with no mods at alland are a game/Proton-level fault, not introduced by this change; a Proton
issue report is being filed separately. Full per-object motion raises that
fault's incidence, so camera-only stays the recommended default on Proton.
🤖 Generated with Claude Code